Skip to content

Standardize signature parity testing, add Docker for testing #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2025
Merged

Standardize signature parity testing, add Docker for testing #62

merged 6 commits into from
Oct 28, 2025

Conversation

@kvz
Copy link
Member

@kvz kvz commented Oct 16, 2025 •
edited
Loading

The Node SDK now has cli support for signing payloads, we can use it to compare our own signatures instead of handrolled Node.js code in this repo:

❯ npx transloadit --help
Usage:
  npx transloadit smart_sig    Read Smart CDN params JSON from stdin and output a signed URL.
  npx transloadit sig [--algorithm <name>]    Read params JSON from stdin and output signed payload JSON.

Required JSON fields:
  smart_sig: workspace, template, input
  sig: none (object is optional)
Optional JSON fields:
  smart_sig: expire_at_ms, url_params
  sig: auth.expires and any supported assembly params

As an aside, I added Docker so it's easier to test this SDK on machines that do not have the PHP environment set up.

@kvz kvz mentioned this pull request Oct 27, 2025
Merged
@kvz kvz changed the title Simplify parity, allow docker testing Standardize signature parity testing, add Docker for testing Oct 27, 2025
@kvz kvz marked this pull request as draft October 27, 2025 21:11
@kvz kvz self-assigned this Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

Coverage report for commit: 6a0021d
File: ./build/logs/clover.xml

Summary - Lines: 91.02% | Methods: 69.57%
FilesLinesMethodsBranches
lib/transloadit
   CurlRequest.php91.67%66.67%100.00%
   CurlResponse.php100.00%100.00%100.00%
   Transloadit.php86.55%55.56%100.00%
   TransloaditRequest.php95.92%71.43%100.00%
   TransloaditResponse.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

@kvz kvz marked this pull request as ready for review October 28, 2025 15:52
@kvz kvz merged commit e3c707d into main Oct 28, 2025
6 checks passed
@kvz kvz deleted the simple-parity branch October 28, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kvz kvz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvz